feat: runtimeclass default support #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
prometherion
force-pushed
the
feat/default-runtimeclass
branch
2 times, most recently
from
6bc92e4 to
04106c8
Compare
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
prometherion
force-pushed
the
feat/default-runtimeclass
branch
from
04106c8 to
264d73b
Compare
oliverbaehler
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM! Don't forget to add it to the documentation: https://github.com/projectcapsule/website/blob/main/content/en/docs/tenants/enforcement.md#runtimeclasses
|
Damn, totally forgot about the docs! I'll be on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1163 by extending the Tenant's
RuntimeClassesspecification key as we already do with Priority Class.