Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): introduce new installation and CRD lifecycle #1065

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

oliverbaehler
Copy link
Collaborator

@oliverbaehler oliverbaehler commented May 3, 2024

With this PR we are addressing the distribution of our CRDs and are trying to reconcile the Helm Chart as the main way of installing Capsule. With this change we can keep our overheads little and focus on one way of distribution. While implementing the CRDs i also did some refactoring of certain helm values.

Implements:

Copy link

netlify bot commented May 3, 2024

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit ecb4035
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/665c37cf5294f20008ad4a98

.goreleaser.yml Outdated Show resolved Hide resolved
hack/argocd.yaml Outdated Show resolved Hide resolved
@MaxFedotov
Copy link
Collaborator

Hi @oliverbaehler,

what do you think about the method with a job that giantswarm uses to update crds - https://github.com/giantswarm/kube-prometheus-stack-app/tree/a8315a8/helm/prometheus-operator-app/templates/crd-install. Seems like that will help to achieve what you want, but will be completely backward-compatible.

@prometherion
Copy link
Member

+1 for @MaxFedotov approach, it's the same approach used by HAProxy Technologies for their Kubernetes Ingress Controller.

@oliverbaehler oliverbaehler force-pushed the feat/crd-ditribution branch 2 times, most recently from 7b2b19d to da8b89f Compare May 27, 2024 16:39
Signed-off-by: Oliver Bähler <[email protected]>
@oliverbaehler oliverbaehler force-pushed the feat/crd-ditribution branch 2 times, most recently from 468793c to f239f47 Compare May 27, 2024 17:13
@oliverbaehler oliverbaehler force-pushed the feat/crd-ditribution branch from f239f47 to 842eb3b Compare May 27, 2024 17:22
Signed-off-by: Oliver Bähler <[email protected]>
Copy link
Collaborator

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliverbaehler oliverbaehler merged commit 9ebbbed into projectcapsule:main Jun 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants