fix: allow wildcards on certificate generation #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I commented in the issue linked to this PR, I think this doesn't work: wildcard domains require the DNS01 challenge. May I ask you if you smoke-tested this change in your cluster? |
|
Smoke test here, LGTM to get merged. |
prometherion
approved these changes
Sep 13, 2024
oliverbaehler
approved these changes
Sep 16, 2024
|
@ppodevlabs pls gpg sign all commits |
|
@ppodevlabs in case you missed last message by Oliver, thanks for the contribution! |
ppodevlabs
force-pushed
the
fix/fix-wildcards-on-certificates
branch
3 times, most recently
from
fa274b5
to
bd6c500
Compare
Signed-off-by: Pedro Parra Ortega <[email protected]>
ppodevlabs
force-pushed
the
fix/fix-wildcards-on-certificates
branch
from
bd6c500
to
715b6a5
Compare
sorry for the delay, i don't know where my notifications went... hehehe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #523