Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add impersonation group filter options #375

Merged

Conversation

oliverbaehler
Copy link
Collaborator

@oliverbaehler oliverbaehler commented Jan 23, 2024

Adds options to filter groups that will be impersonated. We experienced based on the correction in (#331) that the performance greatly decreased because of the amount of groups we have in the claim and the resulting requests to the API server.

With these options the amount of groups which are considered for impersonated can be decreased resulting in less requests.

@MaxFedotov wdyt? Do you also experience performance issues? did you also change the qos and burst of the kube client?

Maybe we can do additional adjustments to improve the performance. But i can't think of anything else to decrease the requests made to the API to request impersonation. Batching all the groups would help, however there's nothing on the kubernetes API which would offer such a function.

Maybe adding FlowSchemes and APIPriority might also help.

@oliverbaehler oliverbaehler force-pushed the feat/performance-improvements branch 2 times, most recently from 3171849 to 795bab8 Compare January 23, 2024 12:46
@prometherion
Copy link
Member

Maybe adding FlowSchemes and APIPriority might also help.

Isn't this already fixable with client-based QPS and burst?

capsule-proxy/main.go

Lines 85 to 86 in fcfa171

flag.Float32Var(&clientConnectionQPS, "client-connection-qps", 20.0, "QPS to use for interacting with kubernetes apiserver.")
flag.Int32Var(&clientConnectionBurst, "client-connection-burst", 30, "Burst to use for interacting with kubernetes apiserver.")

@oliverbaehler
Copy link
Collaborator Author

@prometherion Yes sure

@oliverbaehler oliverbaehler added this to the 0.6.0 milestone Jan 23, 2024
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I remember we had similar issues with #306, maybe @msergg and @y0psolo could be interested.

@oliverbaehler oliverbaehler merged commit 951b53f into projectcapsule:main Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants