feat(controller): add impersonation group filter options #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to filter groups that will be impersonated. We experienced based on the correction in (#331) that the performance greatly decreased because of the amount of groups we have in the claim and the resulting requests to the API server.
With these options the amount of groups which are considered for impersonated can be decreased resulting in less requests.
@MaxFedotov wdyt? Do you also experience performance issues? did you also change the qos and burst of the kube client?
Maybe we can do additional adjustments to improve the performance. But i can't think of anything else to decrease the requests made to the API to request impersonation. Batching all the groups would help, however there's nothing on the kubernetes API which would offer such a function.
Maybe adding FlowSchemes and APIPriority might also help.