Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webtoken auth #195

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix webtoken auth #195

merged 2 commits into from
Mar 6, 2022

Conversation

jessecorson
Copy link
Contributor

@jessecorson jessecorson commented Mar 4, 2022 •
edited
Loading

Issue: the regex pattern for the checkBearerToken function currently does not support webtokens.

Solution: This PR added makes it so that both webtokens and jwts pass the regex

Reference #194

prometherion
prometherion approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM: let's check for the CI!

@prometherion prometherion linked an issue Mar 4, 2022 that may be closed by this pull request
Bearer token regex breaking ability to authenticate #194
Closed
prometherion
prometherion requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And golangci-lint strikes again! Could you please address the issues?

@jessecorson
Copy link
Contributor Author

@prometherion hopefully those have been addressed

@jessecorson jessecorson requested a review from prometherion March 4, 2022 20:30
@mendrugory mendrugory mentioned this pull request Mar 6, 2022
Closed
@prometherion prometherion merged commit bdd736d into projectcapsule:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion Awaiting requested review from prometherion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bearer token regex breaking ability to authenticate
2 participants
@jessecorson @prometherion