Merge pull request #440 from projectcaluma/fix-filter-export

feat(export): add filtering support

emeis/core/tests/test_views.py

@@ -254,10 +254,12 @@ def test_user_export(client, user_factory, acl_factory, snapshot):
     user = user_factory()
     acl_factory.create_batch(9)
     acl_factory.create_batch(2, user=user)
+    # this user should not be exported
+    user_factory(is_active=False)
 
     url = reverse("user-export")
 
-    response = client.get(url)
+    response = client.get(url, {"filter[isActive]": "true"})
 
     assert response.status_code == HTTP_200_OK
 

emeis/core/views.py

@@ -114,7 +114,7 @@ def get_queryset(self):
     @action(methods=["get"], detail=False)
     def export(self, request):
         """Export user list as excel table."""
-        queryset = self.get_queryset()
+        queryset = self.filter_queryset(self.get_queryset())
 
         # we use a template to set the headers to bold and align the columns to fit on a DIN-A4 page
         workbook = openpyxl.load_workbook(settings.USER_EXPORT_TEMPLATE_PATH)

emeis/settings.py

@@ -42,7 +42,14 @@ def default(default_dev=env.NOTSET, default_prod=env.NOTSET):
 ]
 
 if ENV == "dev":
-    INSTALLED_APPS.append("django_extensions")
+    try:
+        __import__("django_extensions")
+        INSTALLED_APPS.append("django_extensions")
+    except ImportError:  # pragma: no cover
+        # Nothing bad, just won't have django-extensions
+        # niceties installed (Most likely Emeis was built
+        # without dev dependencies)
+        pass
 
 MIDDLEWARE = [
     "django.middleware.security.SecurityMiddleware",