This repository has been archived by the owner on Oct 22, 2019. It is now read-only.
Use quorum=True for etcd reads in IPAM. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| handle_id, | ||
| attributes) | ||
| try: | ||
| ips = self._auto_assign_block(block_id, |
There was a problem hiding this comment.
If this is the last block and you get a KeyError (because the client creating this block hasn't written it yet) - shouldn't we be retrying rather than potentially creating a new affine block below.
spikecurtis
force-pushed
the
ipam-quorum-read
branch
from
1b43dcf to
7893c7a
Compare
| allocated_ips = [] | ||
|
|
||
| num_remaining = num | ||
| while num_remaining > 0: | ||
| try: | ||
| block_id = block_ids.next() | ||
| except StopIteration: | ||
| block_id = block_ids.pop() |
There was a problem hiding this comment.
pop(0) could have been used instead of needing to reverse the list - but not fussed either way
There was a problem hiding this comment.
Today I Learned...
spikecurtis
force-pushed
the
ipam-quorum-read
branch
from
7893c7a to
f880765
Compare
|
LGTM |
spikecurtis
pushed a commit
that referenced
this pull request
Nov 5, 2015
Use quorum=True for etcd reads in IPAM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47