Updated the import for logrus to use lowercasing #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgleung
changed the title
This was referenced Jul 28, 2017
robbrockbank
approved these changes
Jul 31, 2017
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 19, 2021
Set client ID for k8s network policy syncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any time we use a package that also imports logrus, they should be updated to use the user's updated user name (which is lowercased). This will prevent import errors with the vendoring going forward.
Found when implementing projectcalico/calicoctl#1564
Details can be found here: sirupsen/logrus#451
Todos
Release Note