Reduce FV verbosity #2814
Merged
Reduce FV verbosity #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore infra logs during stop. Log command output inline rather than buffer.
fasaxc
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
release-note-required
labels
nelljerram
requested changes
May 17, 2021
| for _, profile := range profiles.Items { | ||
| utils.AddToTestOutput(fmt.Sprintf("%v\n", profile)) | ||
| log.Info(profile) |
There was a problem hiding this comment.
I did not know you could call Info with a single object arg....
fv/utils/utils.go
Outdated
| } else { | ||
| log.WithFields(log.Fields{ | ||
| "command": command, | ||
| "args": args}).Infof("Command succeeded:\n%s", output) |
There was a problem hiding this comment.
I think it's going to be a bit confusing having command=kubectl whatever appended to the last line of the output. Can we revert to logging the command on its own first? It's not a big deal for me, but I think that would be better.
There was a problem hiding this comment.
Yes, was just thinking the same myself after trying this out for a bit 👍
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
fasaxc
pushed a commit
to fasaxc/felix
that referenced
this pull request
May 18, 2021
Reduce FV verbosity
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Release Note