Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delimiter to block key #7

Merged

Conversation

robbrockbank
Copy link

@robbrockbank robbrockbank commented May 9, 2017

@robbrockbank
Copy link
Author

robbrockbank commented May 9, 2017

I think this is required. Looking at the logs, the key does not include the terminating "/", so we need to include it in our key construction.

However, the logs also indicated that the block branch was never being hit (and I've tested that code in isolation and it seems fine) - so I also think that the 0.11.1 confd in our calico/node may not have been the correct build. This is speculation.

Logs:

2017-05-08T23:31:26Z rlb-kdd-with-routing-rpqr confd[74]: DEBUG Getting key /calico/ipam/v2/host/rlb-kdd-with-routi
ng-rpqr/ipv4/block
2017-05-08T23:31:26Z rlb-kdd-with-routing-rpqr confd[74]: DEBUG map[]

@caseydavenport
Copy link
Member

LGTM - let me know how the testing goes :)

@robbrockbank robbrockbank merged commit 90f6e1c into projectcalico:master May 9, 2017
@robbrockbank robbrockbank deleted the add-delimiter-to-block-key branch May 9, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants