Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better IPv6 addr match check when starting node #936

Merged
merged 1 commit into from
Apr 22, 2016

Conversation

TrimBiggs
Copy link
Contributor

Fixes #901

@robbrockbank
Copy link
Contributor

It looks fine, but I can't help thinking the get_host_ips() should really return a list of IPAddress objects. Wonder if we should update it. More work though.

@TrimBiggs
Copy link
Contributor Author

I updated to reflect your comment, see the libcalico change projectcalico/libcalico#105, which must be merged before this can be merged.

@robbrockbank
Copy link
Contributor

You should grep the code for instances of get_host_ps. We also use this in the ST utils class - that'll need fixing up.

@TrimBiggs
Copy link
Contributor Author

I've updated this to fix the use of get_host_ips in test_util.py.

@robbrockbank
Copy link
Contributor

LGTM

@TrimBiggs TrimBiggs merged commit 70546fe into projectcalico:master Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants