Build all architectures for calicoctl

[mgleung]

Description

Ensures that all of the architectures that we support are built and uploaded on each release for the calicoctl utility. Fixes https://github.com/projectcalico/calicoctl/issues/2269

Todos

• Tests
• Documentation
• Release note

Release Note

None required

s

[Brian-McM]

Could you please move VALIDARCHES above the include for the common makefile

[Brian-McM]

So my other comment is slightly wrong, what you need to do is set EXCLUDEARCH to empty before the common makefile include:

ARCHES ?= $(patsubst docker-image/Dockerfile.%,%,$(wildcard docker-image/Dockerfile.*))

# Some repositories keep their Dockerfile(s) in the root directory instead of in
# the 'docker-image' subdir. Make sure ARCHES gets filled in either way.
ifeq ($(ARCHES),)
    ARCHES=$(patsubst Dockerfile.%,%,$(wildcard Dockerfile.*))
endif

# list of arches *not* to build when doing *-all
#    until s390x works correctly
EXCLUDEARCH ?= s390x
VALIDARCHES = $(filter-out $(EXCLUDEARCH),$(ARCHES))

^^ that's in the common Makefile. The "sub" targets that are created on the include require the VALIDARCHES be set before the include.