[BPF] detach cali programs from devices no longer in regex #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it from tc package to bpf package with some code reorganization for simplicity. Also lock the clean up lock whenupdating XDP. It wasn't synced till now.
We need that to list programs only attached by calico and not attached to other ifaces by someone else. We may want to clean up someof these if we are not interested in a device anymore.
marvin-tigera
added
docs-pr-required
tomastigera
added
docs-not-required
mazdakn
reviewed
Nov 18, 2022
It can happen that the device regexp changes and calico programs then remain attached to devices that we do not observe anymore. For instance, user has the default ethX in the regexp, but those devices are bonded and the user does not have bondX in the regexp. The user fixes the regexp to include bondX only, but then the programs stay attached to ethX. User has to remove the programs manually or restart the node. We figure out that the programs on devices not in regexp are ours when those programs have a jump map pinned inthe calico bpffs hierarchy. This is not really a problem for workload devices as they usually disapear and programs get detached then.
tomastigera
force-pushed
the
tomas-bpf-hep-unload
branch
from
27b1ace to
05ea9a9
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.