Fix IP address truncation when using autodetection mode "k8s-internal-ip" #6228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Tigera
added
cherry-pick-candidate
docs-not-required
marvin-tigera
added
the
release-note-required
caseydavenport
approved these changes
Jun 15, 2022
|
This has been backported as #6234 and is part of the 3.23.2 release |
caseydavenport
added
cherry-pick-completed
ruslanloman
pushed a commit
to ruslanloman/rke2-charts
that referenced
this pull request
Aug 31, 2022
- There is a bug with ip_autodetection mode "k8s-internal-ip" in
calico 3.23.1 projectcalico/calico#6142 and it was fixed
in 3.23.2 version projectcalico/calico#6228
ruslanloman
pushed a commit
to ruslanloman/rke2-charts
that referenced
this pull request
Sep 2, 2022
- There is a bug with ip_autodetection mode "k8s-internal-ip" in
calico 3.23.1 projectcalico/calico#6142 and it was fixed
in 3.23.2 version projectcalico/calico#6228
- Update tigera-operator version to v1.27.12. It's latest version that
supports calico 3.23.3
This was referenced Sep 2, 2022
rbrtbnfgl
pushed a commit
to rancher/rke2-charts
that referenced
this pull request
Sep 2, 2022
- There is a bug with ip_autodetection mode "k8s-internal-ip" in
calico 3.23.1 projectcalico/calico#6142 and it was fixed
in 3.23.2 version projectcalico/calico#6228
- Update tigera-operator version to v1.27.12. It's latest version that
supports calico 3.23.3
github-actions bot
pushed a commit
to rancher/rke2-charts
that referenced
this pull request
Sep 2, 2022
- There is a bug with ip_autodetection mode "k8s-internal-ip" in
calico 3.23.1 projectcalico/calico#6142 and it was fixed
in 3.23.2 version projectcalico/calico#6228
- Update tigera-operator version to v1.27.12. It's latest version that
supports calico 3.23.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug fix corrects the behaviour of calico-node to truncate/mask IP addresses when using the "k8s-internal-ip" autodetection setting.
New unit tests introduced to verify that both v4 and v6 addresses are returned as expected.
Related issues/PRs
fixes 6141 and 6142
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.