Fix conversion #5993
Merged
Fix conversion #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
docs-pr-required
caseydavenport
added
docs-not-required
marvin-tigera
removed
release-note-required
|
/sem-approve |
caseydavenport
approved these changes
May 4, 2022
|
/sem-approve |
Behnam-Shobiri
added a commit
to Behnam-Shobiri/calico
that referenced
this pull request
May 30, 2022
* fix the string to int conversion * fix the string to int conversion * fix the string to int conversion * fix formating
3 tasks
Behnam-Shobiri
added a commit
to Behnam-Shobiri/calico
that referenced
this pull request
May 31, 2022
* fix the string to int conversion * fix the string to int conversion * fix the string to int conversion * fix formating
3 tasks
lmm
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Bumps github.com/prometheus/client_golang from 1.11.0 to 1.12.1. * bump github.com/distribution/distribution from 2.7.1 to 2.8.1 * Bump github.com/spf13/viper from 1.8.1 to 1.11.0 * Fix conversion (#5993) * fix the string to int conversion * fix the string to int conversion * fix the string to int conversion * fix formating * viper to 1.12 & etcd to 3.5.4 * fix the missing go.sum entry * Fix k8sfv lint issue CGO enabled, switching GOROOT to /usr/local/go-cgo. k8sfv/pod.go:71:8: SA1019: handle.Delete is deprecated: use Close instead which is in line with typical resource release patterns for files and other resources. (staticcheck) defer handle.Delete() ^ make: *** [Makefile:570: golangci-lint] Error 1 Co-authored-by: Tomas Hruby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the string to int conversion.
Add upper bound check for converting strings to int (and int to Uint16).
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.