Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get-IsDSRSupported command not found #5903

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Apr 13, 2022

Description

This needs to be tested but it should fix #5774

Need to pick this back to v3.22

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix Calico for Windows install script not enabling WinDSR on EKS

While this is only used in EKS we'll probably end up putting more and
more of this script's functions in calico.psm1
@lmm lmm requested a review from a team as a code owner April 13, 2022 17:28
@marvin-tigera marvin-tigera added this to the Calico v3.24.0 milestone Apr 13, 2022
@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Apr 13, 2022
@lmm lmm added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact release-note-required Change has user-facing impact (no matter how small) cherry-pick-candidate hold-merge and removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented release-note-not-required Change has no user-facing impact labels Apr 13, 2022
@lmm lmm modified the milestones: Calico v3.24.0, Calico v3.23.0 Apr 13, 2022
@lmm lmm merged commit dcde766 into projectcalico:master Apr 13, 2022
@lmm lmm deleted the lmm-fix-eks-dsr branch April 13, 2022 22:13
@lmm lmm removed the hold-merge label Apr 13, 2022
@lmm lmm mentioned this pull request Apr 13, 2022
3 tasks
@mgleung mgleung added cherry-pick-completed PR has been cherry-picked and removed cherry-pick-candidate labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed PR has been cherry-picked docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-calico-windows.ps1 EnableWinDsrForEKS checks do not work
4 participants