-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to improve reliability of token monitor #5597
Closed
caseydavenport
wants to merge
6
commits into
projectcalico:master
from
caseydavenport:more-robust-token-watch
Closed
Changes to improve reliability of token monitor #5597
caseydavenport
wants to merge
6
commits into
projectcalico:master
from
caseydavenport:more-robust-token-watch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
docs-pr-required
Change is not yet documented
release-note-required
Change has user-facing impact (no matter how small)
labels
Feb 9, 2022
caseydavenport
added
docs-not-required
Docs not required for this change
and removed
docs-pr-required
Change is not yet documented
labels
Feb 9, 2022
marvin-tigera
removed
release-note-required
Change has user-facing impact (no matter how small)
docs-not-required
Docs not required for this change
labels
Apr 21, 2022
This improvement was released?
|
My way to install calico is
|
We ended up going a different direction so the changes in this PR weren't needed. I'd recommend opening an issue to track discussion of the problems you're seeing in your cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've seen a few issues where it looks like our token monitor isn't spotting that the token changes. This is meant to try to improve the reliability of the monitor by:
Related issues/PRs
Related to #4857
Todos
Release Note