Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore route reflector tests #1419

Merged

Conversation

nelljerram
Copy link
Member

No description provided.

@nelljerram
Copy link
Member Author

This should pass CI once projectcalico/confd#71 and projectcalico/routereflector#3 have merged.

@emanic
Copy link
Contributor

emanic commented Nov 29, 2017

@neiljerram You can rebase off the latest master to resolve the htmlproofer errors.

@nelljerram
Copy link
Member Author

Thanks @robbrockbank and @caseydavenport .

I'm wondering though, if I need to add something to _data/versions.yml to reference a particular version of calico/routereflector - which I guess also means that it becomes a release artefact - and machinery in the routereflector repo to push tagged images to dockerhub and quay. Currently that machinery is missing and the ST process here just pulls calico/routereflector:latest. (How is that working....?)

@nelljerram
Copy link
Member Author

So specifically, I'd now propose:

WDYT?

@nelljerram nelljerram force-pushed the restore-route-reflector-tests branch from ed35da3 to c5fc46b Compare November 30, 2017 16:25
@nelljerram
Copy link
Member Author

nelljerram commented Nov 30, 2017

(Just rebased.)

Also I previously just released calico/routereflector v0.5.0, so would expect the CI now to pass on this PR...

Neil Jerram and others added 4 commits December 1, 2017 00:08
(But not yet tests that involve a cluster of route reflectors.)
This was accidentally changed from 64514 to 12345, while this test was
disabled, by commit 03fec6d.
@nelljerram nelljerram force-pushed the restore-route-reflector-tests branch from ad296ac to 73583ac Compare December 1, 2017 00:10
@nelljerram nelljerram merged commit f0d6ba7 into projectcalico:master Dec 1, 2017
@nelljerram nelljerram deleted the restore-route-reflector-tests branch December 1, 2017 00:42
nelljerram pushed a commit to nelljerram/calico that referenced this pull request Dec 1, 2017
This is similar to projectcalico#1429 but for TestBase.assert_ip_connectivity
(connectivity to IP addresses) instead of
TestBase.assert_connectivity (connectivity to workloads).  (I saw a case
of TestBase.assert_ip_connectivity failing, in test_autodetection.py,
while testing for projectcalico#1419.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants