-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore route reflector tests #1419
Restore route reflector tests #1419
Conversation
This should pass CI once projectcalico/confd#71 and projectcalico/routereflector#3 have merged. |
@neiljerram You can rebase off the latest master to resolve the htmlproofer errors. |
Thanks @robbrockbank and @caseydavenport . I'm wondering though, if I need to add something to _data/versions.yml to reference a particular version of calico/routereflector - which I guess also means that it becomes a release artefact - and machinery in the routereflector repo to push tagged images to dockerhub and quay. Currently that machinery is missing and the ST process here just pulls calico/routereflector:latest. (How is that working....?) |
So specifically, I'd now propose:
WDYT? |
ed35da3
to
c5fc46b
Compare
(Just rebased.) Also I previously just released calico/routereflector v0.5.0, so would expect the CI now to pass on this PR... |
f1b2feb
to
ad296ac
Compare
(But not yet tests that involve a cluster of route reflectors.)
This was accidentally changed from 64514 to 12345, while this test was disabled, by commit 03fec6d.
ad296ac
to
73583ac
Compare
This is similar to projectcalico#1429 but for TestBase.assert_ip_connectivity (connectivity to IP addresses) instead of TestBase.assert_connectivity (connectivity to workloads). (I saw a case of TestBase.assert_ip_connectivity failing, in test_autodetection.py, while testing for projectcalico#1419.)
No description provided.