Support Rails 5 #1483
Support Rails 5 #1483
Conversation
| @@ -14,5 +14,9 @@ class MastheadUploader < CarrierWave::Uploader::Base | |||
| def store_dir | |||
| "uploads/#{model.class.to_s.underscore}/#{mounted_as}/#{model.id}" | |||
| end | |||
|
|
|||
| def default_url | |||
| ActionController::Base.helpers.asset_path("fallback/" + [version_name, "default.png"].compact.join('_')) | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @search.attributes = search_params | ||
| @search.query_params = params.except(:exhibit_id, :search, *blacklisted_search_session_params).reject { |_k, v| v.blank? } | ||
| @search.attributes = search_params. | ||
| @search.query_params = params.to_unsafe_h.except(:exhibit_id, :search, *blacklisted_search_session_params).reject { |_k, v| v.blank? } |
There was a problem hiding this comment.
unexpected token tIVAR
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
There was a problem hiding this comment.
Looks like a trailing dot on this line.
cbeer
force-pushed
the
rails5
branch
3 times, most recently
from
e31a2ed to
dd5163b
Compare
| initialize_routing_helpers(helper) | ||
| end | ||
|
|
||
| def initialize_routing_helpers(helpers) |
There was a problem hiding this comment.
Unused method argument - helpers. If it's necessary, use _ or _helpers as an argument name to indicate that it won't be used. You can also write as initialize_routing_helpers(*) if you want the method to accept any arguments but don't care about them.
cbeer
force-pushed
the
rails5
branch
3 times, most recently
from
0cde78c to
8b4e470
Compare
| @@ -13,7 +13,7 @@ class SearchesController < Spotlight::ApplicationController | |||
|
|
|||
| def create | |||
| @search.attributes = search_params | |||
| @search.query_params = params.except(:exhibit_id, :search, *blacklisted_search_session_params).reject { |_k, v| v.blank? } | |||
| @search.query_params = params.to_unsafe_h.with_indifferent_access.except(:exhibit_id, :search, *blacklisted_search_session_params).reject { |_k, v| v.blank? } | |||
cbeer
force-pushed
the
rails5
branch
2 times, most recently
from
590794c to
6236925
Compare
|
Should we as to the README that you need particular branches of the dependencies to use it with Rails 5 |
|
Possibly a good thing to discuss next week. Hopefully it's down to just two sources now, and I'd be optimistic that friendly_id will get a new release fairly soon, and I wonder if we should drop |
Fixes #1468