Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each key makes it's own list #3312

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Each key makes it's own list #3312

merged 1 commit into from
Sep 3, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Sep 3, 2024

This fixes a misunderstanding of how Hash.new(obj) works. That means each key gets the same instance of the list rather than a new list

sandbergja
sandbergja approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jcoyne

@jcoyne
Each key makes it's own list
2cb96d9 
This fixes a misunderstanding of how Hash.new(obj) works. That means each key gets the same instance of the list rather than a new list
@sandbergja sandbergja merged commit 067671d into main Sep 3, 2024
13 checks passed
@sandbergja sandbergja deleted the fix-bug branch September 3, 2024 14:33
cbeer pushed a commit that referenced this pull request Sep 21, 2024
@jcoyne @cbeer
Make sure each semantic value gets a new list; backports #3312
350f273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoyne @sandbergja