Provide aria-label for main navigation #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
label-main-navigation
branch
from
bb7ba45
to
06605c1
Compare
jcoyne
commented
Aug 15, 2024
| @@ -1,4 +1,4 @@ | |||
| <nav class="navbar navbar-expand-md navbar-dark bg-dark topbar" role="navigation"> | |||
| <nav class="navbar navbar-expand-md navbar-dark bg-dark topbar" aria-label="<%= aria_label %>"> | |||
There was a problem hiding this comment.
We don't need the role="navigtion" because the role is implied https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nav#technical_summary
jcoyne
force-pushed
the
label-main-navigation
branch
from
06605c1
to
84b51ac
Compare
jrochkind
approved these changes
Aug 21, 2024
tpendragon
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.