Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rubocop gems and auto-update #3193

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add missing rubocop gems and auto-update #3193

merged 1 commit into from
Jun 13, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 13, 2024

No description provided.

@mjgiarlo mjgiarlo merged commit bea5b57 into main Jun 13, 2024
12 checks passed
@mjgiarlo mjgiarlo deleted the rubocop-capybara branch June 13, 2024 16:03
@jrochkind
Copy link
Member

jrochkind commented Jun 13, 2024

Any idea what made be_a_kind_of, that apparently previously worked, stop working and have to be changed to be_a?

(The mystery might be why be_a_kind_of ever worked! The correct method name, that I think still would be working as a synonum to be_a, is be_kind_of (no _a_))

@jcoyne
Copy link
Member Author

jcoyne commented Jun 13, 2024

@jrochkind I think it's just a matter of preference. https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecclasscheck is the rule

@mjgiarlo
Copy link
Member

@jrochkind 💬

Any idea what made be_a_kind_of, that apparently previously worked, stop working and have to be changed to be_a?

(The mystery might be why be_a_kind_of ever worked! The correct method name, that I think still would be working as a synonum to be_a, is be_kind_of (no _a_))

RSpec allows a bunch of different forms: https://github.com/rspec/rspec-expectations/blob/main/lib/rspec/matchers.rb#L372-L382

@jrochkind
Copy link
Member

Ah, so it had to be changed in this PR becuase you enabled a rubocop rule that forced it to be changed? Okeydoke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants