Wrap template generator code in an after_bundle block #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
template
branch
from
ea70e42
to
fbe4793
Compare
jcoyne
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jcoyne for finding this solution! I am just writing it up.
We were encountering the issues recorded here: #3031, where
config/importmap.rbwas not being created when installing Blacklight from the template as described in the Quickstart guide "easy way" (generate blacklight:installitself worked correctly, but when invoked from the template, the rails install process was not executing in full).Wrapping the code in this
after_bundleblock fixes the issue. See the commit message from Rails here: rails/rails@83e69c2#diff-4521b0667f0d930737cfa0a1ced7dd5c00a15909503123cf3752a6c6ebfcca04