Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Blacklight::Gallery::OpenseadragonEmbedComponent #155

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Sep 23, 2024

No description provided.

@cbeer cbeer marked this pull request as ready for review September 23, 2024 22:14
@jcoyne
Copy link
Member

jcoyne commented Sep 23, 2024

Should view_component be added as a dependency, or can we assume it is provided by BL?

@cbeer
Copy link
Member Author

cbeer commented Sep 24, 2024

I think we can assume, because it's inheriting from Blacklight::Component, not ViewComponent::Base, right?

@jcoyne jcoyne merged commit 51405c3 into main Sep 24, 2024
6 checks passed
@jcoyne jcoyne deleted the OpenseadragonEmbedComponent branch September 24, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants