Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mint a unique HTML ID prefix for the OSD HTML elements #116

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Mint a unique HTML ID prefix for the OSD HTML elements #116

merged 1 commit into from
Mar 1, 2022

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Feb 24, 2022

thatbudakguy
thatbudakguy approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, i think this is the only (simple) solution that supports embedding multiple viewers of the same object on a page, where we wouldn't otherwise have any unique metadata to use for the ID.

@cbeer cbeer merged commit ac60d71 into master Mar 1, 2022
@cbeer cbeer deleted the osd-html-id branch March 1, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatbudakguy thatbudakguy thatbudakguy approved these changes

@corylown corylown corylown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all zoomable images have the same id for controls
3 participants
@cbeer @corylown @thatbudakguy