This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
syscontainers: ensure destdir exist #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Works for me, I tested in the same conditions that made it fail before. In any case, last word to @miabbott @rh-atomic-bot delegate=miabbott |
|
✌️ @miabbott can now approve this pull request |
|
bot, retest this please |
|
Seems pretty straightforward! Tested fine for me on a F27 Cloud system |
|
⚡ Test exempted: pull fully rebased and already tested. |
eyusupov
pushed a commit
to eyusupov/atomic
that referenced
this pull request
Mar 10, 2018
Closes: projectatomic#1138 Closes: projectatomic#1140 Approved by: miabbott
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
destdirdoesn't exist already exist the command would fail. This change creates thedestdirbefore doing the firststat.Related Issue Numbers
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.