-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add a ML model artifact test case #2332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 92.86% 92.85% -0.01%
==========================================
Files 167 167
Lines 22038 22038
==========================================
- Hits 20465 20463 -2
- Misses 981 982 +1
- Partials 592 593 +1 ☔ View full report in Codecov by Sentry. |
bffa5e1
to
165c8e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier you had been using 'run regctl', was the content of 'lines' or 'output' variable not enough to get the shasum or index/manifest? Or why did you switch to using files?
When pulling the artifact, didn't want to hold it in a output var - could be very large. |
Both as a test and an example. Inspired by: https://github.com/kubeflow/model-registry/blob/main/docs/logical_model.md Signed-off-by: Ramkumar Chinchani <[email protected]>
Both as a test and an example.
Inspired by:
https://github.com/kubeflow/model-registry/blob/main/docs/logical_model.md
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.