Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a ML model artifact test case #2332

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

rchincha
Copy link
Contributor

Both as a test and an example.

Inspired by:
https://github.com/kubeflow/model-registry/blob/main/docs/logical_model.md

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

test/blackbox/pushpull_authn.bats Outdated Show resolved Hide resolved
test/blackbox/pushpull_authn.bats Show resolved Hide resolved
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (8b4abc6) to head (4dfc69d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
- Coverage   92.86%   92.85%   -0.01%     
==========================================
  Files         167      167              
  Lines       22038    22038              
==========================================
- Hits        20465    20463       -2     
- Misses        981      982       +1     
- Partials      592      593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha rchincha force-pushed the ml branch 3 times, most recently from bffa5e1 to 165c8e2 Compare March 20, 2024 22:08
@rchincha rchincha requested a review from andaaron March 20, 2024 22:50
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier you had been using 'run regctl', was the content of 'lines' or 'output' variable not enough to get the shasum or index/manifest? Or why did you switch to using files?

examples/config-minimal.json Outdated Show resolved Hide resolved
@rchincha
Copy link
Contributor Author

Earlier you had been using 'run regctl', was the content of 'lines' or 'output' variable not enough to get the shasum or index/manifest? Or why did you switch to using files?

When pulling the artifact, didn't want to hold it in a output var - could be very large.
The rest were removed first to verify output and later to make the usage uniform.

@andaaron andaaron merged commit 4105f12 into project-zot:main Mar 21, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants