-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added swagger doc generation for mgmt and userprefs #1530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokirisaki
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
June 19, 2023 08:05
andaaron
reviewed
Jun 19, 2023
andaaron
reviewed
Jun 19, 2023
andaaron
reviewed
Jun 19, 2023
aokirisaki
force-pushed
the
swagger-doc
branch
2 times, most recently
from
June 19, 2023 09:31
f7dec6e
to
7b3ebc8
Compare
andaaron
previously approved these changes
Jun 19, 2023
eusebiu-constantin-petu-dbk
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 91.19% 91.16% -0.03%
==========================================
Files 114 114
Lines 22757 22757
==========================================
- Hits 20753 20747 -6
- Misses 1495 1500 +5
- Partials 509 510 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Lisca Ana-Roberta <[email protected]>
aokirisaki
dismissed stale reviews from eusebiu-constantin-petu-dbk and andaaron
via
June 19, 2023 11:14
bc0ec42
andaaron
approved these changes
Jun 19, 2023
eusebiu-constantin-petu-dbk
approved these changes
Jun 19, 2023
laurentiuNiculae
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.