Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): consolidate extensions headers returned to UI by ext… #1473

Merged
merged 1 commit into from
May 25, 2023

Conversation

eusebiu-constantin-petu-dbk
Copy link
Collaborator

…ensions

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pkg/common/common.go Outdated Show resolved Hide resolved
alexstan12
alexstan12 previously approved these changes May 25, 2023
Copy link
Contributor

@alexstan12 alexstan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1473 (fc28091) into main (2b8479f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
+ Coverage   90.95%   90.97%   +0.02%     
==========================================
  Files         103      103              
  Lines       22608    22605       -3     
==========================================
+ Hits        20562    20565       +3     
+ Misses       1524     1520       -4     
+ Partials      522      520       -2     
Impacted Files Coverage Δ
pkg/common/common.go 94.05% <100.00%> (+0.61%) ⬆️
pkg/extensions/extension_mgmt.go 90.24% <100.00%> (-0.24%) ⬇️
pkg/extensions/extension_search.go 100.00% <100.00%> (+2.72%) ⬆️
pkg/extensions/extension_userprefs.go 90.72% <100.00%> (-0.71%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 9acd19f into project-zot:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants