fix(zb): fixed remote repositories cleanup #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
previously approved these changes
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 90.80% 90.83% +0.02%
==========================================
Files 99 99
Lines 22162 22168 +6
==========================================
+ Hits 20125 20137 +12
+ Misses 1522 1517 -5
+ Partials 515 514 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eusebiu-constantin-petu-dbk
force-pushed
the
fix_zb_cleanup
branch
from
016fcdc
to
69835a5
Compare
andaaron
previously approved these changes
May 19, 2023
fix(storage/local): also put deduped blobs in cache, not just origin blobs this caused an error when trying to delete deduped blobs from multiple repositories fix(storage/s3): check blob is present in cache before deleting this is an edge case where dedupe is false but cacheDriver is not nil (because in s3 we open the cache.db if storage find it in rootDir) it caused an error when trying to delete blobs uploaded with dedupe false Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_zb_cleanup
branch
from
69835a5
to
aaafbcb
Compare
andaaron
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(storage): also put deduped blobs in cache, not just origin blobs
this caused an error when trying to delete deduped blobs from multiple repositories
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.