Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update referrers response #1415

Merged

Conversation

laurentiuNiculae
Copy link
Contributor

@laurentiuNiculae laurentiuNiculae commented May 3, 2023

What type of PR is this?

Which issue does this PR fix:
Closes #1410

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1415 (e080645) into main (d17fe00) will increase coverage by 0.00%.
The diff coverage is 83.09%.

@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files          99       99           
  Lines       22153    22176   +23     
=======================================
+ Hits        20107    20130   +23     
  Misses       1526     1526           
  Partials      520      520           
Impacted Files Coverage Δ
pkg/storage/s3/s3.go 82.67% <72.41%> (+0.14%) ⬆️
pkg/storage/local/local.go 81.14% <86.66%> (+0.13%) ⬆️
pkg/api/routes.go 94.47% <100.00%> (+0.01%) ⬆️
pkg/extensions/sync/signatures.go 87.85% <100.00%> (ø)
pkg/extensions/sync/utils.go 89.08% <100.00%> (ø)
pkg/meta/update.go 99.16% <100.00%> (ø)
pkg/test/common.go 84.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/storage/local/local.go Outdated Show resolved Hide resolved
pkg/storage/s3/s3.go Outdated Show resolved Hide resolved
…t field

- as requested by the latest version of the oci distribution spec

Signed-off-by: Laurentiu Niculae <[email protected]>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 7d7bc9d into project-zot:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: referrers API MUST respond with the response header OCI-Subject: true
3 participants