fix(routes): get blob upload session should include 'bytes=' in Range… #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
conformance_fix
branch
2 times, most recently
from
a8e3f0e to
07e48d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 98 98
Lines 21480 21480
=======================================
Hits 19445 19445
Misses 1521 1521
Partials 514 514
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range
|
jdolitsky
previously approved these changes
Apr 12, 2023
|
The range responses were modified as part of https://github.com/project-zot/zot/pull/596/files |
eusebiu-constantin-petu-dbk
force-pushed
the
conformance_fix
branch
from
07e48d6 to
9f37b57
Compare
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
eusebiu-constantin-petu-dbk
force-pushed
the
conformance_fix
branch
from
9f37b57 to
e9c24b6
Compare
rchincha
force-pushed
the
conformance_fix
branch
from
e9c24b6 to
ea9b30f
Compare
… header needed to change because of OCI distribution spec change in test: https://github.com/opencontainers/distribution-spec/blob/main/conformance/02_push_test.go#L223 Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
conformance_fix
branch
from
ea9b30f to
69a195c
Compare
|
i think this can be closed, we just merged opencontainers/distribution-spec#401 with missing bytes prefix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… header
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.