Use kernel mount of squashfs if running privledged. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
feature/root-kernel-squash-mounts
branch
from
1093459 to
bf68312
Compare
hallyn
reviewed
Dec 14, 2022
smoser
force-pushed
the
feature/root-kernel-squash-mounts
branch
from
bf68312 to
fe1eac4
Compare
hallyn
reviewed
Dec 14, 2022
Try to mount a squashfs image with a kernel mount. This should be faster than squashfuse mount, but will only work if we are host root. Environment variable STACKER_ALLOW_SQUASHFS_KERNEL_MOUNTS can control whether or not kernel mounts can be tried. It defaults to 'true', but if it is set to 'false', then no attempt will be made. Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
feature/root-kernel-squash-mounts
branch
from
fe1eac4 to
b592695
Compare
hallyn
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If stacker build is being run as "real root", then use a kernel mount rather than using squashfuse.
What does this PR do / Why do we need it: Maybe we dont. It seems unreasonable to hamstring root into only doing fuse mounts when he/she could have the kernel do them.
I expect some discussion would be needed here. I'm thinking that maybe environment variable configuration to turn this on or off would be useful. Maybe default to fuse and allow the root user of stacker to use kernel mounts by setting STACKER_SQUASHFS_KERNEL_MOUNTS=true . or something.