Determine the actual used local address with ENET socket #387
Conversation
| } | ||
| } | ||
|
|
||
| if (SConfig::GetInstance().m_slippiForceLanIp) |
There was a problem hiding this comment.
You're confident enough this will work for everyone to remove the override?
There was a problem hiding this comment.
I moved this block to the top (line 363) to make the priority order more clear (override > new determination mechanism > fallback old determination mechanism)
| // Fetch the last IP (because that was correct for me, not sure if it will be for all) | ||
| int i = 0; | ||
| while (host_entry->h_addr_list[i] != 0) | ||
| // Fallback: just try the last local IP address listed. They seem to be |
There was a problem hiding this comment.
I feel like all of the local address stuff might as well be moved to its own function?
There was a problem hiding this comment.
I tried to leave the old determination method alone to have a nicer diff but it didn't work out I guess. You want me to move just this old block?
There was a problem hiding this comment.
cleaned up the fallback method a bit and factored it out to a separate method. good call looks a lot nicer now imo
NikhilNarayana
force-pushed
the
localaddress
branch
from
7bac72a
to
9c2587a
Compare
NikhilNarayana
changed the title
tested this switching between wifi, ethernet, and VPN