Fix macOS Ventura #373
Merged
Fix macOS Ventura #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS Ventura appears to be broken due to a change in how mach exception handling works; this breaks the exception handling that Dolphin relies on internally. It took me forever to realize this but one of Jos's comments kept rolling around in my head and made me start looking here.
Of course, once I understood what the issue was, it's actually a relatively simple fix - and OatmealDome apparently had to do the same thing over in mainline:
dolphin-emu/dolphin@3e5f1a4
In this PR I've also gone ahead and disabled wxWidgets fatal exception handling on macOS, as that was completely obscuring what the actual issue was and made this way more annoying to deal with as a result. With it turned off, Apple's standard stack trace window reports the actual issue fairly clearly. I left it on for other platforms as I don't want to mess with any potential debugging setups that may exist for them.
I've tested this on my M1 w/ Ventura and on my old 2015 with Catalina, but I'm relatively confident in the fix as it's pretty much what mainline does here as well.