macOS: Default to Vulkan for rendering #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors a change in mainline Dolphin, so should be relatively safe to do. Slippi's MoltenVK setup is a bit older than modern Dolphin's, but most users still see a jump in performance in comparison to Apple's broken OpenGL API. High Sierra remains defaulted to OpenGL, as Metal on that platform lacks critical pieces that Dolphin requires.
altf4
pushed a commit
to altf4/Ishiiruka
that referenced
this pull request
Dec 21, 2021
* Change macOS to default to Vulkan in 10.14+. This mirrors a change in mainline Dolphin, so should be relatively safe to do. Slippi's MoltenVK setup is a bit older than modern Dolphin's, but most users still see a jump in performance in comparison to Apple's broken OpenGL API. High Sierra remains defaulted to OpenGL, as Metal on that platform lacks critical pieces that Dolphin requires.
jordan-zilch
pushed a commit
to jordan-zilch/Ishiiruka
that referenced
this pull request
May 17, 2022
* Change macOS to default to Vulkan in 10.14+. This mirrors a change in mainline Dolphin, so should be relatively safe to do. Slippi's MoltenVK setup is a bit older than modern Dolphin's, but most users still see a jump in performance in comparison to Apple's broken OpenGL API. High Sierra remains defaulted to OpenGL, as Metal on that platform lacks critical pieces that Dolphin requires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors a recent change in mainline Dolphin, so should be relatively safe to do. Tested locally (Big Sur M1, Catalina Intel) and no issues found, but I lack a High Sierra machine to test on. I am reasonably confident it'll be fine though.
I've wanted to PR this for quite some time but was unsure if I'd be missing some context, but mainline having done it coupled with most Slippi macOS users needing it for performance makes me far more confident.