Adapter hot swapping and fix crash when disconnecting adapter on macOS #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On macOS 11.0 I noticed that the libusb hotplug event was getting called on the read thread. This seemed to be different behavior than my windows platform where the hotplug event was happening on it's own thread * when a hotplug detach event happens the reset thread waits for the in and out threads to error out with "join" * however, on macOS 11.0 (when started with an adapter plugged in), the detach event would attempt to join itself causing a crash. * To get around this before trying to join threads reset will try to see if it is one of those threads and start a new reset thread if so. * If we wait attempt to join the reset thread from the caller they will both be trying to join each other which will also result in a crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Closes #301
Combines the two PRs into one and fixes merge conflicts so I could get testing done.