IGNORE: combination PR for merge testing #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually specialize `Clone` for all of the primitive types that are used in `PrimitiveSet`s.
It is valid for a Rust `std::io::Read` object to read less than the size of the provided buffer, even when more data is available (unlike Go's `io::ReadFull`, which only does a partial read if EOF is truly encountered). Cope with this, and explicitly test for it too. Fixes #68
Move main set of protobufs into a new tink-proto crate, and also move the testing protobufs into the tink-testing crate. Update all imports to pull in from the new places.
This removes dev-dependencies from the tink functional crates
daviddrysdale
force-pushed
the
all-the-things
branch
from
427125f
to
e3d4f99
Compare
daviddrysdale
force-pushed
the
all-the-things
branch
from
e3d4f99
to
4585f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #60 + #69 + #64