Preparatory commits from #801 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
If any kind of failure occurs when proxying a gRPC method invocation, ensure that an error response is sent on the invocation's response channel to prevent the caller blocking forever.
tiziano88
approved these changes
Apr 14, 2020
| @@ -37,39 +37,40 @@ std::string DataFrom(const std::string& filename) { | |||
|
|
|||
| TEST(WasmNode, MalformedFailure) { | |||
| // No magic. | |||
| ASSERT_EQ(nullptr, WasmNode::Create(nullptr, "test", "", "oak_main")); | |||
| ASSERT_EQ(nullptr, WasmNode::Create(nullptr, "test", 0, "", "oak_main")); | |||
There was a problem hiding this comment.
Maybe create a constant to avoid this magic number.
There was a problem hiding this comment.
Left as-is as it's due to be deleted soon.
| @@ -831,12 +890,15 @@ impl super::Node for WasmNode { | |||
| .name(self.to_string()) | |||
| .spawn(move || { | |||
| let pretty_name = pretty_name_for_thread(&thread::current()); | |||
| let wasi_stub = WasiStub {}; | |||
There was a problem hiding this comment.
Suggested change
| let wasi_stub = WasiStub {}; | |
| let wasi_stub = WasiStub; |
Equivalent to the C++ placeholders in oak/server/wasm_node.cc added in #529.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the preparatory commits of #801 to reduce the (large) amount of merging that's going to be needed for that PR.
Checklist
cover any TODOs and/or unfinished work.
construction.