Rust Oak Loader #749
Merged
Rust Oak Loader #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
reviewed
Mar 23, 2020
|
Should |
|
Definitely not under SDK :) |
15 tasks
tiziano88
approved these changes
Apr 7, 2020
Comment on lines
73
to
75
| let error_msg = format!("Runtime error: {:?}", error); | ||
| error!("{}", error_msg); | ||
| error_msg |
There was a problem hiding this comment.
I'm not sure I get the point of logging something here and also returning it. Doesn't it end up being logged twice?
There was a problem hiding this comment.
Deleted logging, but kept explanation messages
|
|
||
| fn read_file(filename: &str) -> Result<Vec<u8>, std::io::Error> { | ||
| let mut file = File::open(filename).map_err(|error| { | ||
| error!("Couldn't open file \"{}\": {:?}", filename, error); |
There was a problem hiding this comment.
Does the std::io::Error not contain any information at all?
There was a problem hiding this comment.
It doesn't contain filename, so it just says: couldn't open a file
tiziano88
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Rust version of the Oak Loader
Fixes #723
Checklist
construction.