Define gRPC Invocation in Rust SDK #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
force-pushed
the
tzn_grpc_invocation
branch
from
3a2c025 to
32abe8d
Compare
daviddrysdale
approved these changes
Jan 28, 2020
| @@ -0,0 +1,44 @@ | |||
| /// A gRPC invocation, consisting of exactly two channels: one to read incoming requests from the | |||
There was a problem hiding this comment.
Need a license header.
- Encapsulate a request receiver and a response sender into a single object which implements `Encodable` and `Decodable`. - Add `#[must_use]` to a couple places where return status codes were not checked. We should probably consider using `Result` types everywhere. Fixes project-oak#528
tiziano88
force-pushed
the
tzn_grpc_invocation
branch
from
32abe8d to
2ebeaa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object which implements
EncodableandDecodable.#[must_use]to a couple places where return status codes werenot checked. We should probably consider using
Resulttypeseverywhere.
Fixes #528
Checklist
cover any TODOs and/or unfinished work.
construction.