Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gRPC client pseudo-node in Rust runtime #844

Closed
tiziano88 opened this issue Apr 15, 2020 · 3 comments · Fixed by #909
Closed

Implement gRPC client pseudo-node in Rust runtime #844

tiziano88 opened this issue Apr 15, 2020 · 3 comments · Fixed by #909
Assignees
@ipetr0v
Labels
lang/Rust P0
Milestone
Trusted Aggregator

Comments

@tiziano88
Copy link
Collaborator

Similar to the existing C++ implementation: https://github.com/project-oak/oak/blob/2f257f2b32286bef1615c44bceb3a413346c5919/oak/server/grpc_client_node.h .

@ipetr0v have you looked into this already by any chance, as part of the gRPC server pseudo-node work?
@tiziano88 tiziano88 added this to the Trusted Aggregator milestone Apr 15, 2020
@tiziano88 tiziano88 mentioned this issue Apr 15, 2020
Closed
@ipetr0v
Copy link
Contributor

ipetr0v commented Apr 20, 2020 •
edited
Loading

I haven't looked much into this yet, but I think we will be able to use tonic::client

@ipetr0v ipetr0v mentioned this issue Apr 20, 2020
Closed
15 tasks
@ipetr0v
Copy link
Contributor

ipetr0v commented Apr 24, 2020 •
edited
Loading

Since tonic uses rustls (that doesn't support checking certificates using IP addresses yet: rustls/rustls#184), we will always need to have a domain name defined for an external gRPC service:
https://github.com/hyperium/tonic/blob/f6ecaff0de76de16cb1f680dc3473c8cf2bbaddd/examples/src/tls/client.rs#L13-L15

@ipetr0v ipetr0v self-assigned this Apr 24, 2020
@ipetr0v
Copy link
Contributor

ipetr0v commented Apr 24, 2020

Also, do we need to authenticate a gRPC client Node to for an external gRPC service?
Probably can be a separate PR (if we need this feature).

@ipetr0v ipetr0v mentioned this issue Apr 27, 2020
Merged
1 task
@tiziano88 tiziano88 added the P0 label May 11, 2020
ipetr0v added a commit that referenced this issue May 13, 2020
@ipetr0v
Add gRPC client pseudo-Node (#909)
af79230 
This change adds a gRPC client pseudo-Node.

Fixes #844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipetr0v ipetr0v

Labels
lang/Rust P0
Projects
None yet
Milestone
Trusted Aggregator
Development

Successfully merging a pull request may close this issue.

Add gRPC client pseudo-Node ipetr0v/oak
2 participants
@tiziano88 @ipetr0v