add machine client api pkg #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a client API to get and put a machine. This is used by trust to edit a machine's boot source, iso and disks. Signed-off-by: Serge Hallyn <[email protected]>
Just have cmd/machine/cmd/ and cmd/machined/cmd be the main packages for each executable respectively. (Maybe we should drop cmd/ there) Give the full module name in go.mod Signed-off-by: Serge Hallyn <[email protected]>
hallyn
force-pushed
the
2023-09-26/api
branch
from
db1ec7a
to
1b247c8
Compare
|
Looking at getMachines And this PR makes only Get and Put machine ... shouldn't the client API include all of these? for example, console does a Post to the machines//console URL . Do you see adding those after this? or should they all go in now? |
|
I figured we'd add them as they're needed, but I don't mind either way. I can add them now if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a client API to get and put a machine. This is used by trust to edit a machine's boot source, iso and disks.