Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of fixes for code submission backend #108

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Conversation

ali-ramadhan
Copy link
Member

Bunch of fixes:

  1. The "submit code" button was relying on the value of the language dropdown to determine the submission's language. So lots of people were probably getting weird errors when trying to submit code files. The language is now determined from the file extension. So this actually resolves Submitting code via upload button doesn't work #57.
  2. I was messing up the file paths for code submissions and they were getting saved in two places with different file paths. This is now fixed, and each submission just saves one file in one place. I won't delete or reorganize previous submissions since this will require rewriting database entries which doesn't seem worth it.

Resolves #57
Resolves #104

@ali-ramadhan ali-ramadhan merged commit 06cc7bc into main Mar 28, 2021
@ali-ramadhan ali-ramadhan deleted the ali/fix-media-uploads branch March 28, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple media directories for uploads Submitting code via upload button doesn't work
1 participant