-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "id" support. Refactor Writers. Add Writer additional format extensibility. #78
Conversation
… easy extensibility for new formats
… Add decollate_batch when writing.
Need to fix some DDP issues first |
Done, ready for merge |
Sorry, this PR escalated 😅📈 happy to sit down/have a call if you want to go through it together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff with the writer! Love the flexibility.
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.32 to 3.1.35. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.32...3.1.35) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2023.5.7 to 2023.7.22. - [Commits](certifi/python-certifi@2023.05.07...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Do you think the Writers should support |
I think |
Description
interval
argument. The batch samples are added as a table record (TableWriter) or written to a file (FileWriter) at each batch end.additional_writers
argument, or by calling.add_writer()
method after the instantiation.gather_tensors
and usedecollate_batch
instead to support writing batch size > 1Related Issue
#47
#23 (partially, all sys.exits() replaced)
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.