Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify batch splitting, add None collate support for when target is not expected #65

Merged
merged 6 commits into from
May 14, 2023

Conversation

ibro45
Copy link
Collaborator

@ibro45 ibro45 commented May 9, 2023

Description

  • Removed the overcomplicated and unreliable batch type inference in forward and criterion calculation
  • LighterSystem always expects two elements - input and target, or a dict with "input" and "target" keys.
  • Target can be None if no label is used for the task. Added support for collating None's.
  • Improved parse_data

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ibro45 ibro45 requested a review from surajpaib May 9, 2023 15:19
@ibro45 ibro45 mentioned this pull request May 11, 2023
11 tasks
@surajpaib
Copy link
Collaborator

Looks great overall. Much needed change!

@ibro45 ibro45 merged commit f25361e into main May 14, 2023
@ibro45 ibro45 deleted the w2s1 branch May 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants