Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance common module code documentation #736

Merged

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 24, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-13958

What changes have been made

Enhanced common module code documentation

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (1f026b8) to head (c2761cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          36       36           
  Lines        2417     2417           
=======================================
  Hits         2275     2275           
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@ChristianZaccaria
Copy link
Collaborator

ChristianZaccaria commented Oct 24, 2024

I'm making a few changes in this repo's settings:

  • We are dropping the merge queue feature as it seems it's not properly maintained with major issues found unresolved for over a year.
  • One benefit seen from merge queue is that it ensures PRs are tested against the target branch. Since we won't be using this feature, I've enabled "Require branches to be up to date before merging" GitHub feature in this repo. By enabling this, all PRs will require to rebase before they can be merged and this way ensure code stability and integration.

I'll have a PR up to properly streamline our processes, in the meantime, we need to add the e2e label to trigger the e2e tests.

Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Just to confirm, do we want to cover code documentation on only the public functions in the common module?

@Ygnas
Copy link
Contributor Author

Ygnas commented Oct 25, 2024

Great work!

Just to confirm, do we want to cover code documentation on only the public functions in the common module?

It could cover the private ones as well, but I don't see any private functions appear in the sphinx documentation.

@ChristianZaccaria
Copy link
Collaborator

@Ygnas Yeah that's what I thought as well. Perhaps, the private functions can continue to have simple comments while the public functions include the enhanced code documentation for sphynx.

Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a couple of comments

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac1a1dc into project-codeflare:main Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants