-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance common module code documentation #736
Enhance common module code documentation #736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 36 36
Lines 2417 2417
=======================================
Hits 2275 2275
Misses 142 142 ☔ View full report in Codecov by Sentry. |
8540143
to
1b29e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm making a few changes in this repo's settings:
I'll have a PR up to properly streamline our processes, in the meantime, we need to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Just to confirm, do we want to cover code documentation on only the public functions in the common module?
It could cover the private ones as well, but I don't see any private functions appear in the sphinx documentation. |
@Ygnas Yeah that's what I thought as well. Perhaps, the private functions can continue to have simple comments while the public functions include the enhanced code documentation for sphynx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a couple of comments
1b29e35
to
4d7b365
Compare
4d7b365
to
fb23e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fb23e92
to
c2761cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ac1a1dc
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-13958
What changes have been made
Enhanced common module code documentation
Verification steps
Checks