Raise CodeFlare operator Go patch version to match AppWrapper #628
+10
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dgrove-oss
reviewed
Nov 15, 2024
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/openshift/client-go v0.0.0-20221019143426-16aed247da5c | |||
| github.com/project-codeflare/appwrapper v0.27.0 | |||
| github.com/project-codeflare/codeflare-common v0.0.0-20240930133152-11fd6e3be6b3 | |||
| github.com/ray-project/kuberay/ray-operator v1.1.1 | |||
| github.com/ray-project/kuberay/ray-operator v1.2.1 | |||
There was a problem hiding this comment.
This is brought by Kueue 0.8.3 dependency. That is why I had to rewrite it below.
dgrove-oss
reviewed
Nov 15, 2024
| replace github.com/project-codeflare/appwrapper v0.27.0 => github.com/project-codeflare/appwrapper v0.27.1-0.20241105160939-f71c6326acce | ||
|
|
||
| // These replace directives deal with the backlevel ODH kueue version | ||
| replace sigs.k8s.io/kueue v0.8.3 => github.com/opendatahub-io/kueue v0.7.0-odh-2 |
There was a problem hiding this comment.
you probably still need a replace directive for kueue, just to a different odh version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
N/A
What changes have been made
Align CodeFlare operator Go patch version with AppWrapper to avoid compatibility workarounds.
Verification steps
E2E tests pass.
Checks