Ensure db mapping aliases commandName for commands and add response Names #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility) and that commands by cluster contain response names
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Mar 27, 2023
brdandu
approved these changes
Mar 27, 2023
andy31415
added a commit
to project-chip/connectedhomeip
that referenced
this pull request
Mar 28, 2023
…matter IDL files (#25853) * Generate all client-side commands and structures. This requires zap updates after project-chip/zap#981 * ZAP regen all * Use zap 2023.03.27 to pick up clusterName and responseName access * Update minimum zap version * Start using zcl_commands_source_client instead of chip_cluster_responses * Update invoke callbacks too to use updated stateless loop methods * Noop update: switch loop method and conditional that is not needed * Switch to source_server instead of source_client --------- Co-authored-by: Andrei Litvin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make codegen simpler in matter SDK:
commandNameas an alias tonamemakes things interop between#all_outgoing_commands_for_clusterandzcl_commands_source_client(and overallzcl_commandsvszcl_commands_source_*).responseName/RESPONSE_NAMEis useful to interop between things like#all_outgoing_commands_for_clusterand#zcl_commandsand#zcl_commands_source_*