disabling GUI buttons of forced External Storage #1181
Conversation
paulr34
force-pushed
the
gui_forced_external
branch
from
b865a16
to
838b364
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 65.43% 65.48% +0.04%
==========================================
Files 185 185
Lines 19104 19124 +20
Branches 4092 4093 +1
==========================================
+ Hits 12501 12523 +22
+ Misses 6603 6601 -2 ☔ View full report in Codecov by Sentry. |
|
Seeing a lot of changes to the matter code gen. Is this expected? See all .matter files with diffs. |
Yes, they look right. For example, in Access Control we see
the default for this external attribute is set to null |
Zigbee doesn't have attributeAccessInterface Good catch, I made this commit to limit it to Matter data 3bc7a3a As long as Zigbee does not have attributeAccessInterface in their zcl.json then it won't effect it but it would definitely be a good idea to add a cypress test |
paulr34
force-pushed
the
gui_forced_external
branch
from
3bc7a3a
to
bce50bb
Compare
| @@ -25,7 +25,7 @@ const dbMapping = require('./db-mapping.js') | |||
| const queryPackage = require('./query-package.js') | |||
| const dbEnum = require('../../src-shared/db-enum.js') | |||
| const queryZcl = require('./query-zcl.js') | |||
| const queryUpgrade = require('../upgrade/upgrade.js') | |||
| const queryUpgrade = require('../matter/matter.js') | |||
There was a problem hiding this comment.
As a matter of general rules: we should NOT use the .js suffix in require calls.
That allows you to migrate the specific file to a different language (like TS) without having to modify these requires.
There was a problem hiding this comment.
okay ill make a new PR for going through and fixing that for all the files
| @@ -108,7 +109,8 @@ function httpGetPackageNotifications(db) { | |||
| function httpGetPackageNotificationsByPackageId(db) { | |||
| return async (request, response) => { | |||
| let packageId = request.params.packageId | |||
| let notifications = await queryPackageNotification.getNotificationByPackageId(db, packageId) | |||
| let notifications = | |||
| await queryPackageNotification.getNotificationByPackageId(db, packageId) | |||
There was a problem hiding this comment.
Why do we have these formatting diffs? Do we not all use the same formatter?
This PR addresses both issues:
#1086,
#1145
If attribute storage policy is attributeAccessInterface then the storage and the default field are not editable. It also sets default value to null.
The default field is still there but it is disabled.